[GitHub] [dubbo-go] binbin0325 commented on a diff in pull request #2097: upgrade nacos version to 2.1.0

[GitBox <gi...@apache.org>]

binbin0325 commented on code in PR #2097:
URL: https://github.com/apache/dubbo-go/pull/2097#discussion_r1013719209


##########
metadata/report/nacos/report_test.go:
##########
@@ -151,7 +151,7 @@ func (mr *MockIConfigClientMockRecorder) CancelListenConfig(params interface{})
 }
 
 // SearchConfig mocks base method
-func (m *MockIConfigClient) SearchConfig(param vo.SearchConfigParam) (*model.ConfigPage, error) {
+func (m *MockIConfigClient) SearchConfig(param vo.SearchConfigParm) (*model.ConfigPage, error) {

Review Comment:
   v2.1.2 vo.SearchConfigParm 应该是SearchConfigParam



##########
Makefile:
##########
@@ -72,3 +72,4 @@ verify: clean license test
 clean: prepare
 	rm -rf coverage.txt
 	rm -rf license-header-checker*
+

Review Comment:
   空行



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org