You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/13 15:42:20 UTC
[GitHub] [doris] morningman opened a new pull request, #15919: [fix](multi-catalog) fix bug that replay init catalog may happen after catalog is dropped
morningman opened a new pull request, #15919:
URL: https://github.com/apache/doris/pull/15919
# Proposed changes
Issue Number: close #xxx
## Problem summary
init catalog and init db can happen at any time,
even after catalog or db is dropped.
Because it may already hold the catalog or db object before they are being dropped.
So just skip the edit log if object does not exist.
```
2023-01-13 22:48:17,638 ERROR (stateListener|86) [EditLog.loadJournal():998] Operation Type 10325
java.lang.IllegalArgumentException: null
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:128) ~[spark-dpp-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
at org.apache.doris.datasource.CatalogMgr.replayInitCatalog(CatalogMgr.java:517) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:948) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.catalog.Env.replayJournal(Env.java:2647) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.catalog.Env.transferToMaster(Env.java:1394) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.catalog.Env.access$1200(Env.java:292) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2563) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.0-SNAPSHOT]
```
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15919: [fix](multi-catalog) fix bug that replay init catalog may happen after catalog is dropped
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15919:
URL: https://github.com/apache/doris/pull/15919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gavinchou commented on pull request #15919: [fix](multi-catalog) fix bug that replay init catalog may happen after catalog is dropped
Posted by GitBox <gi...@apache.org>.
gavinchou commented on PR #15919:
URL: https://github.com/apache/doris/pull/15919#issuecomment-1382039469
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15919: [fix](multi-catalog) fix bug that replay init catalog may happen after catalog is dropped
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15919:
URL: https://github.com/apache/doris/pull/15919#issuecomment-1382177328
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.85 seconds
load time: 488 seconds
storage size: 17122673937 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230113173612_clickbench_pr_80098.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org