You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 16:08:30 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1073: ci: fix e2e test cases unstable
nic-chen opened a new pull request #1073:
URL: https://github.com/apache/apisix-dashboard/pull/1073
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
___
### Bugfix
- Description
When testing balancing, the statistics on different upstream accesses often deviate from expectations, causing test cases to fail.
- How to fix?
use single worker APISIX to test balancing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1073: ci: fix e2e test cases unstable
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1073:
URL: https://github.com/apache/apisix-dashboard/pull/1073#discussion_r546181387
##########
File path: api/test/docker/apisix_config2.yaml
##########
@@ -42,6 +42,7 @@ apisix:
nginx_config:
error_log_level: "debug"
+ worker_processes: "1"
Review comment:
default is 'auto'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1073: ci: fix e2e test cases unstable
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1073:
URL: https://github.com/apache/apisix-dashboard/pull/1073#discussion_r546179575
##########
File path: api/test/docker/apisix_config2.yaml
##########
@@ -42,6 +42,7 @@ apisix:
nginx_config:
error_log_level: "debug"
+ worker_processes: "1"
Review comment:
1 is the default value for worker_processes, why we need to add it? 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1073: ci: fix e2e test cases unstable
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1073:
URL: https://github.com/apache/apisix-dashboard/pull/1073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1073: ci: fix e2e test cases unstable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1073:
URL: https://github.com/apache/apisix-dashboard/pull/1073#issuecomment-748178997
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1073?src=pr&el=h1) Report
> Merging [#1073](https://codecov.io/gh/apache/apisix-dashboard/pull/1073?src=pr&el=desc) (96084ae) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/fc05b7df453f6e1ed052eaf151105fbd5c1f82a4?el=desc) (fc05b7d) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1073?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1073 +/- ##
=======================================
Coverage 40.50% 40.50%
=======================================
Files 27 27
Lines 1627 1627
=======================================
Hits 659 659
Misses 873 873
Partials 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1073?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1073?src=pr&el=footer). Last update [fc05b7d...96084ae](https://codecov.io/gh/apache/apisix-dashboard/pull/1073?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1073: ci: fix e2e test cases unstable
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1073:
URL: https://github.com/apache/apisix-dashboard/pull/1073#discussion_r546181864
##########
File path: api/test/docker/apisix_config2.yaml
##########
@@ -42,6 +42,7 @@ apisix:
nginx_config:
error_log_level: "debug"
+ worker_processes: "1"
Review comment:
fine, I find it https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org