You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Yx01-me (via GitHub)" <gi...@apache.org> on 2026/08/27 17:24:51 UTC

[PR] test(desktop): expand Storybook smoke theme coverage [maka]

Yx01-me opened a new pull request, #4042:
URL: https://github.com/apache/maka/pull/4042

   ## Summary
   
   - Run every Storybook story with the default palette in both light and dark color schemes.
   - Run the Native Conversation reference story across all 11 palettes and both color schemes.
   - Include scheme and palette context in Storybook smoke URLs, diagnostics, and tests without expanding the full catalog across every palette.
   
   Refs #3942
   
   ## Verification
   
   - `node --test scripts/ci-test-plan.test.mjs scripts/storybook-visual-smoke.test.mjs scripts/ax-tree-audit.test.mjs`
   - `npm run lint`
   - `npm run format:check`
   - `npm run typecheck`
   - `npm run build`
   - `npx knip --workspace apps/desktop`
   - `npx knip --workspace packages/ui`
   - `npm --workspace @maka/desktop run smoke:storybook` — 410 renders across 195 stories
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex assisted with the Storybook theme job matrix implementation, tests, and local verification.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(desktop): expand Storybook smoke theme coverage [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4042:
URL: https://github.com/apache/maka/pull/4042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(desktop): expand Storybook smoke theme coverage [maka]

Posted by "Yx01-me (via GitHub)" <gi...@apache.org>.
Yx01-me commented on code in PR #4042:
URL: https://github.com/apache/maka/pull/4042#discussion_r3886643857


##########
scripts/storybook-visual-smoke.mjs:
##########
@@ -312,7 +336,8 @@ async function runCli() {
   const repoRoot = resolve(scriptDir, '..');
   const staticDir = resolve(process.argv[2] ?? join(repoRoot, 'apps/desktop/storybook-static'));
   const storyIndex = await readFile(join(staticDir, 'index.json'), 'utf8').then(JSON.parse);
-  const jobs = catalogJobs(storyIndex);
+  const { THEME_PALETTES } = await import('@maka/core/settings');

Review Comment:
   I'll solve it soon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(desktop): expand Storybook smoke theme coverage [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #4042:
URL: https://github.com/apache/maka/pull/4042#discussion_r3883294602


##########
scripts/storybook-visual-smoke.mjs:
##########
@@ -312,7 +336,8 @@ async function runCli() {
   const repoRoot = resolve(scriptDir, '..');
   const staticDir = resolve(process.argv[2] ?? join(repoRoot, 'apps/desktop/storybook-static'));
   const storyIndex = await readFile(join(staticDir, 'index.json'), 'utf8').then(JSON.parse);
-  const jobs = catalogJobs(storyIndex);
+  const { THEME_PALETTES } = await import('@maka/core/settings');

Review Comment:
   Thanks for expanding theme coverage without multiplying every story by every palette. **[P2]** This import adds an undeclared build prerequisite to the smoke entrypoint: `@maka/core/settings` resolves to `dist/settings.js`, but `npm --workspace @maka/desktop run smoke:storybook` does not build `@maka/core` first. In a clean worktree, building Storybook and then running the smoke command fails with `ERR_MODULE_NOT_FOUND`; CI hides this because the root build happens earlier. Please make the smoke command establish that prerequisite, or consume the shared palette authority through a path that does not depend on pre-existing Core build output.
   
   <details>
   <summary>简体中文</summary>
   
   谢谢在没有让每个 story 都乘上全部 palette 的前提下扩展主题覆盖。**[P2]** 这个 import 给 smoke 入口增加了一个未声明的构建前置条件:`@maka/core/settings` 会解析到 `dist/settings.js`,但 `npm --workspace @maka/desktop run smoke:storybook` 不会先构建 `@maka/core`。在干净 worktree 中,先构建 Storybook 再运行 smoke 会得到 `ERR_MODULE_NOT_FOUND`;CI 因为更早执行了根目录 build,恰好掩盖了这个问题。请让 smoke 命令显式满足该前置条件,或者从不依赖 Core 预构建产物的路径读取共享 palette authority。
   
   </details>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org