You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/01/29 09:35:05 UTC
[GitHub] [avro] Fokko opened a new pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Fokko opened a new pull request #1069:
URL: https://github.com/apache/avro/pull/1069
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko merged pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #1069:
URL: https://github.com/apache/avro/pull/1069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko edited a comment on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko edited a comment on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443571
The `PUBLIC_DEPRECATED` has been the default since 1.7.4, so the downstream projects should get the warnings for a while. I like to remove this limbo state, and either force users to go public or private (and use the getters and setters). This reduces the noise in the generated templates.
I use the generated classes a lot, and this should not be a problem to me, I prefer to use the getters/setters.
I'll target this for 1.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko removed a comment on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko removed a comment on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443797
I'll target this for 1.11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko commented on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443571
The `PUBLIC_DEPRECATED` has been the default since 1.7.4, so the downstream projects should get the warnings for a while. I like to remove this limbo state, and either force users to go public or private (and use the getters and setters). This reduces the noise in the generated templates.
I use the generated classes a lot, and this should not be a problem to me, I prefer to use the getters/setters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771009708
This looks good to me -- but just a quick thought:
`PUBLIC_DEPRECATED` might still be useful for developers changing their specific compiler settings from PUBLIC to PRIVATE, to warn their downstream projects that a breaking change is coming to their generated classes.
I don't think that's an _extremely_ common use case: as far as I know, we never share generated classes at our company (and only share schemas). What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771476971
Thanks for the confirmation and the cleanup! :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko edited a comment on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko edited a comment on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443571
The `PUBLIC_DEPRECATED` has been the default since 1.7.4, so the downstream projects should get the warnings for a while. I like to remove this limbo state, and either force users to go public or private (and use the getters and setters). This reduces the noise in the generated templates.
I use the generated classes a lot, and this should not be a problem to me, I prefer to use the getters/setters.
I'll target this for 1.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko commented on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443797
I'll target this for 1.11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771476971
Thanks for the confirmation and the cleanup! :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko merged pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #1069:
URL: https://github.com/apache/avro/pull/1069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko removed a comment on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko removed a comment on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443797
I'll target this for 1.11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] Fokko commented on pull request #1069: AVRO-3030: Remove the PUBLIC_DEPRECATED
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #1069:
URL: https://github.com/apache/avro/pull/1069#issuecomment-771443571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org