Re: [PR] Add config option [secrets]backends_order [airflow]

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #45931:
URL: https://github.com/apache/airflow/pull/45931#discussion_r2021018760


##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1265,6 +1265,20 @@ secrets:
       sensitive: true
       example: ~
       default: ""
+    backends_order:
+      description: |
+        Comma-separated list of secret backends. These backends will be used in the order they are specified.
+        Please note that the `environment_variable` and `metastore` are required values and cannot be removed
+        from the list. Supported values are:
+
+        * ``custom``: Custom secret backend specified in the ``secrets[backend]`` configuration option.
+        * ``environment_variable``: Standard environment variable backend
+          ``airflow.secrets.environment_variables.EnvironmentVariablesBackend``.
+        * ``metastore``: Standard metastore backend ``airflow.secrets.metastore.MetastoreBackend``.
+      version_added: 3.0.0
+      type: string
+      example: ~
+      default: "custom,environment_variable,metastore"

Review Comment:
   i am a bit concerned making it just a "hidden" setting.
   I think we better to come up with a way to expose the chosen order in the UI. that way DAG authors can verify and use it for debug for questions like (why I see wrong value in variable).
   
   Also, correct me if I am wrong the order affect only read, not write. maybe the setting should be `backends_read_order?`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org