Re: [PR] [SPARK-49230][Connect][SQL] Do not return UnboundRowEncoder when not needed [spark]

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #49339:
URL: https://github.com/apache/spark/pull/49339#discussion_r1900145819


##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:
##########
@@ -331,7 +331,7 @@ object ScalaReflection extends ScalaReflection {
       case t if isSubtype(t, localTypeOf[java.time.Instant]) => STRICT_INSTANT_ENCODER
       case t if isSubtype(t, localTypeOf[java.time.LocalDateTime]) => LocalDateTimeEncoder
       case t if isSubtype(t, localTypeOf[VariantVal]) => VariantEncoder
-      case t if isSubtype(t, localTypeOf[Row]) => UnboundRowEncoder
+      case t if isRowEncoderSupported && isSubtype(t, localTypeOf[Row]) => UnboundRowEncoder

Review Comment:
   I am curious to find out what will break :)....
   
   Can you also check the call sites that use this flag?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org