[GitHub] [superset] mayurnewase commented on a change in pull request #17414: chore: Take version from latest git tag, correct version in package.json

[GitBox <gi...@apache.org>]

mayurnewase commented on a change in pull request #17414:
URL: https://github.com/apache/superset/pull/17414#discussion_r747953557



##########
File path: setup.py
##########
@@ -25,13 +25,22 @@
 BASE_DIR = os.path.abspath(os.path.dirname(__file__))
 
 PACKAGE_JSON = os.path.join(BASE_DIR, "superset-frontend", "package.json")
-with open(PACKAGE_JSON, "r") as package_file:
-    version_string = json.load(package_file)["version"]
 
 with io.open("README.md", "r", encoding="utf-8") as f:
     long_description = f.read()
 
 
+def get_version() -> str:
+    version_string = "1.3.2"  # current latest as last fallback

Review comment:
       this may not be used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org