You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org> on 2012/01/27 21:00:10 UTC

[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly honor setVerifyChecksum

    [ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195055#comment-13195055 ] 

Robert Joseph Evans commented on HADOOP-7998:
---------------------------------------------

I like the patch.  It seems fairly straight forward, but the test you added in seems a bit too whitebox for my taste.  The test requires that the checksum validation be done the way it is currently done.  That may be an OK assumption, but I would rather see the test not need to make that assumption, and instead validate that reading a file with an invalid checksum file will work with verify checksum disabled.
                
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
>                 Key: HADOOP-7998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7998
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira