You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by renato2099 <gi...@git.apache.org> on 2016/01/18 00:09:59 UTC
[GitHub] gora pull request: GORA-459
GitHub user renato2099 opened a pull request:
https://github.com/apache/gora/pull/51
GORA-459
Fixing HBaseClusterSingleton.java unclosed resources returned from HBaseTestingUtility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/renato2099/gora GORA-459
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit b5792a90da4625680367b04f72edad6b6686cb85
Author: Renato Marroquin <re...@gmail.com>
Date: 2016-01-17T23:08:26Z
GORA-459
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172593992
Yeah I can but it would be good to sort the commit issue out.
Are your trying to commit to the Git repos or the Github mirror?
On Monday, January 18, 2016, Renato Marroquin <no...@github.com>
wrote:
> Can you commit this and the other PRs @lewismc
> <https://github.com/lewismc> please? I don't know why I don't have right
> to actually do the merging myself. Thanks man!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/gora/pull/51#issuecomment-172539082>.
>
--
*Lewis*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172539082
Can you commit this and the other PRs @lewismc please? I don't know why I don't have right to actually do the merging myself. Thanks man!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172417218
+1
On Sunday, January 17, 2016, Renato Marroquin <no...@github.com>
wrote:
> Fixing HBaseClusterSingleton.java unclosed resources returned from
> HBaseTestingUtility
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/gora/pull/51
> Commit Summary
>
> - GORA-459
>
> File Changes
>
> - *M*
> gora-hbase/src/test/java/org/apache/gora/hbase/util/HBaseClusterSingleton.java
> <https://github.com/apache/gora/pull/51/files#diff-0> (7)
>
> Patch Links:
>
> - https://github.com/apache/gora/pull/51.patch
> - https://github.com/apache/gora/pull/51.diff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/gora/pull/51>.
>
--
*Lewis*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172681580
got it, then you wanna merge? or should I? :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172683094
If you can then please go ahead. I'm out and about now.
I'll merge this into my HBase branch and submit a PR once it's ready.
Thanks Renato.
On Monday, January 18, 2016, Renato Marroquin <no...@github.com>
wrote:
> got it, then you wanna merge? or should I? [image: :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/gora/pull/51#issuecomment-172681580>.
>
--
*Lewis*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172681318
Yeah it's all commits through the CLI to the canonical source at Apache. As
the Github mirror is not canonical source, the merge functionality is
disabled.
On Monday, January 18, 2016, Renato Marroquin <no...@github.com>
wrote:
> I can commit through the cmd line git commands, but I can't merge the PR
> from the github website, can you do that? or do you the commits directly
> from the cmd line?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/gora/pull/51#issuecomment-172680924>.
>
--
*Lewis*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172680924
I can commit through the cmd line git commands, but I can't merge the PR from the github website, can you do that? or do you the commits directly from the cmd line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-459
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---