You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 16:01:57 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #27820: Add retry option in RedshiftDeleteClusterOperator to retry when an operation is running in the cluster

eladkal commented on code in PR #27820:
URL: https://github.com/apache/airflow/pull/27820#discussion_r1029528934


##########
airflow/providers/amazon/aws/operators/redshift_cluster.py:
##########
@@ -498,22 +502,38 @@ def __init__(
         wait_for_completion: bool = True,
         aws_conn_id: str = "aws_default",
         poll_interval: float = 30.0,
+        retry: bool = False,
+        retry_attempts: int = 10,

Review Comment:
   I think we need some standardization (see https://github.com/apache/airflow/pull/27276#discussion_r1021574968 )
   I think it's better to decide on some standardization and then enforce it across. It's less productive when we discuss this per operator (and also may eventually have different names per operator)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org