You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/10/27 08:19:06 UTC

[GitHub] [incubator-brpc] wayslog commented on pull request #1965: fix: domain name length

wayslog commented on PR #1965:
URL: https://github.com/apache/incubator-brpc/pull/1965#issuecomment-1293163267

   > 建议补充一下边界值的单测
   
   这里有个麻烦的地方在于我没有一个可用的足够长的域名，导致我的返回值无论正确错误都是 -1 的。
   这个地方是否可以考虑开个特例，比如参数不对的时候返回 -2 什么的，这样好做测试？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org