You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/05 13:04:16 UTC

[GitHub] [apisix-dashboard] 96RadhikaJadhav opened a new pull request #969: api(conf/conf.yaml): aligned comments

96RadhikaJadhav opened a new pull request #969:
URL: https://github.com/apache/apisix-dashboard/pull/969


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #969: api: Aligned comments in conf/conf.yaml

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #969:
URL: https://github.com/apache/apisix-dashboard/pull/969#issuecomment-739249039


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/969?src=pr&el=h1) Report
   > Merging [#969](https://codecov.io/gh/apache/apisix-dashboard/pull/969?src=pr&el=desc) (459cd1a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c574813eea82edcd6d95a2ea0f8857b736049717?el=desc) (c574813) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/969/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/969?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #969   +/-   ##
   =======================================
     Coverage   43.49%   43.49%           
   =======================================
     Files          18       18           
     Lines        1299     1299           
   =======================================
     Hits          565      565           
     Misses        642      642           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/969?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/969?src=pr&el=footer). Last update [c574813...459cd1a](https://codecov.io/gh/apache/apisix-dashboard/pull/969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #969: feat: aligned comments conf.yaml

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #969:
URL: https://github.com/apache/apisix-dashboard/pull/969#issuecomment-739254307


   @96RadhikaJadhav 
   
   I think you should modify the commit message and push it again.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] tokers merged pull request #969: feat: aligned comments conf.yaml

Posted by GitBox <gi...@apache.org>.
tokers merged pull request #969:
URL: https://github.com/apache/apisix-dashboard/pull/969


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org