[GitHub] [flink-connector-jdbc] WencongLiu commented on a diff in pull request #40: [FLINK-31793] remove dependency on flink-shaded guava for flink-connector-jdbc

["WencongLiu (via GitHub)" <gi...@apache.org>]

WencongLiu commented on code in PR #40:
URL: https://github.com/apache/flink-connector-jdbc/pull/40#discussion_r1170177527


##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcTypeUtil.java:
##########
@@ -26,7 +26,7 @@
 import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
 import org.apache.flink.table.types.logical.LogicalTypeRoot;
 
-import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableMap;

Review Comment:
   I think this import sentence will be replaced by `org.apache.flink.connector.jdbc.shaded.guava30` after being packaged by maven. Then other java projects which depend on jdbc-connector can import org.apache.flink.connector.jdbc.shaded.guava30. The logic is same with  [PR](https://github.com/apache/flink-connector-cassandra/pull/7) . WDYT? @MartijnVisser 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org