You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by mt...@apache.org on 2010/05/24 07:00:29 UTC
svn commit: r947540 -
/trafficserver/traffic/trunk/iocore/cluster/ClusterAPI.cc
Author: mturk
Date: Mon May 24 05:00:29 2010
New Revision: 947540
URL: http://svn.apache.org/viewvc?rev=947540&view=rev
Log:
Comment code about hazardous usage of NON_MODULAR define
Modified:
trafficserver/traffic/trunk/iocore/cluster/ClusterAPI.cc
Modified: trafficserver/traffic/trunk/iocore/cluster/ClusterAPI.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/iocore/cluster/ClusterAPI.cc?rev=947540&r1=947539&r2=947540&view=diff
==============================================================================
--- trafficserver/traffic/trunk/iocore/cluster/ClusterAPI.cc (original)
+++ trafficserver/traffic/trunk/iocore/cluster/ClusterAPI.cc Mon May 24 05:00:29 2010
@@ -279,6 +279,11 @@ void
clusterAPI_init()
{
MachineStatusSM *mssmp = 0;
+ // XXX: BIG RED WARNING!!! Direct null pointer dereference
+ // Either create MachineStatusSM before ose or axe this function.
+ // It is used only if NON_MODULAR is defined making that
+ // flag crashing ClusterProcessor::init()
+ //
ink_atomiclist_init(&status_callout_atomic_q,
"cluster API status_callout_q", (char *) &mssmp->link.next - (char *) mssmp);
ClusterAPI_mutex = new_ProxyMutex();