Re: [PR] Spark: Async Spark Micro Batch Planner [iceberg]

["RjLi13 (via GitHub)" <gi...@apache.org>]

RjLi13 commented on code in PR #15059:
URL: https://github.com/apache/iceberg/pull/15059#discussion_r2714886011


##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java:
##########
@@ -432,6 +531,8 @@ public void testReadingStreamFromFutureTimetsamp() throws Exception {
 
     // Data appended after the timestamp should appear
     appendData(data);
+    // Allow async background thread to refresh, else test sometimes fails
+    Thread.sleep(50);

Review Comment:
   I'm open to other suggestions. This test sometimes fails, because background thread runs and isn't able to refresh before test finishes executing. Hence I added sleep here to wait before test finishes. In real use case, user should not have issues with this.
   
   It failed for me locally once before this, but ran multiple times without it failing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org