You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/14 23:33:11 UTC

[GitHub] [cordova-android] erisu commented on a change in pull request #1166: feat: overload PluginEntry constructor to set onload property

erisu commented on a change in pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166#discussion_r613650851



##########
File path: framework/src/org/apache/cordova/PluginEntry.java
##########
@@ -52,6 +52,10 @@ public PluginEntry(String service, CordovaPlugin plugin) {
         this(service, plugin.getClass().getName(), true, plugin);
     }
 
+    public PluginEntry(String service, CordovaPlugin plugin, boolean onload) {

Review comment:
       @jblejder would you be able to add in the JavaDoc comment?
   
   You can use the below `public PluginEntry` overloaded method's comment block as an example for your overloaded method.
   
   After this PR is updated, I can merge it in for next release.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org