You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/01 20:26:55 UTC
[GitHub] [incubator-nuttx] PetervdPerk opened a new pull request, #6758: LPC17_40 CAN driver SocketCAN support
PetervdPerk opened a new pull request, #6758:
URL: https://github.com/apache/incubator-nuttx/pull/6758
## Summary
Adds SocketCAN support to LPC17_40 CAN driver
## Impact
Minimal compile switch allows to still use the old character device driver
## Testing
Tested on custom LPC1768 board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6758: LPC17_40 CAN driver SocketCAN support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6758:
URL: https://github.com/apache/incubator-nuttx/pull/6758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] PetervdPerk commented on a diff in pull request #6758: LPC17_40 CAN driver SocketCAN support
Posted by GitBox <gi...@apache.org>.
PetervdPerk commented on code in PR #6758:
URL: https://github.com/apache/incubator-nuttx/pull/6758#discussion_r935984263
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_can.c:
##########
@@ -72,6 +91,14 @@
#if defined(CONFIG_LPC17_40_CAN1) || defined(CONFIG_LPC17_40_CAN2)
+#if defined(CHRDEV_CAN) && defined(SOCKET_CAN)
+# error "Both chrdev CAN or SocketCAN have been enabled"
+#endif
+
+#if defined(CHRDEV_CAN)
+#define lpc17_40_can_s lpc17_40_can_s
Review Comment:
Oh somehow missed that thank your for pointing it out, I've changed it and tested again chrdev mode as well.
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_can.c:
##########
@@ -72,6 +91,14 @@
#if defined(CONFIG_LPC17_40_CAN1) || defined(CONFIG_LPC17_40_CAN2)
+#if defined(CHRDEV_CAN) && defined(SOCKET_CAN)
+# error "Both chrdev CAN or SocketCAN have been enabled"
+#endif
+
+#if defined(CHRDEV_CAN)
+#define lpc17_40_can_s lpc17_40_can_s
Review Comment:
Oh somehow missed that thank you for pointing it out, I've changed it and tested again chrdev mode as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6758: LPC17_40 CAN driver SocketCAN support
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6758:
URL: https://github.com/apache/incubator-nuttx/pull/6758#discussion_r934987899
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_can.c:
##########
@@ -72,6 +91,14 @@
#if defined(CONFIG_LPC17_40_CAN1) || defined(CONFIG_LPC17_40_CAN2)
+#if defined(CHRDEV_CAN) && defined(SOCKET_CAN)
+# error "Both chrdev CAN or SocketCAN have been enabled"
+#endif
+
+#if defined(CHRDEV_CAN)
+#define lpc17_40_can_s lpc17_40_can_s
Review Comment:
Should it be: "#define lpc17_40_s can_dev_s" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org