You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2016/10/25 15:01:35 UTC

[GitHub] nifi issue #1157: NIFI-2791 Adding 'math' expression language function

Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/1157
  
    @pvillard31 I addressed your comment and added to the unit test to verify that it properly handles the exceptions. A couple notes:
    
    1: The exception handling is not pretty. That said, I don't think there is a better/more concise way to do it since we're dealing with configurable reflection calls.
    2: Normally I would have the exception testing in individual tests with an "@Test(expected = AttributeExpressionLanguageException.class)" but since this is a large test class (that probably should be broken up) that tests all the EL and I wanted to keep it concise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---