You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by haohui <gi...@git.apache.org> on 2017/04/06 06:20:29 UTC

[GitHub] flink issue #3675: [FLINK-6261] [table] Support TUMBLE, HOP, SESSION group w...

Github user haohui commented on the issue:

    https://github.com/apache/flink/pull/3675
  
    Thanks for the PR! It looks good to me overall. One problem is that `dataSet.LogicalWindowAggregateRule` has duplicated quite a bit of code in the `dataStream.LogicalWindowAggregateRule`.
    
    Maybe it makes sense to refactor some of the code into a common class, so that we can follow the same pattern for the implementation of the WindowStart / WindowEnd functions?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---