You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/03 19:35:18 UTC

[jira] [Commented] (STORM-1601) Cluster-state must check if znode exists before getting children for storm backpressure

    [ https://issues.apache.org/jira/browse/STORM-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178336#comment-15178336 ] 

ASF GitHub Bot commented on STORM-1601:
---------------------------------------

GitHub user kishorvpatil opened a pull request:

    https://github.com/apache/storm/pull/1181

    [STORM-1601] Check if /backpressure/storm-id node exists before requesting children

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kishorvpatil/incubator-storm storm1601

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1181
    
----
commit 177a4c3ad269855532edc7c00312c7a79e1a4da7
Author: Kishor Patil <kp...@yahoo-inc.com>
Date:   2016-03-03T18:32:19Z

    Check if /backpressure/storm-id before requesting children

----


> Cluster-state must check if znode exists before getting children for storm backpressure
> ---------------------------------------------------------------------------------------
>
>                 Key: STORM-1601
>                 URL: https://issues.apache.org/jira/browse/STORM-1601
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Kishor Patil
>            Assignee: Kishor Patil
>
> You see below exception in the integration tests..
> {panel}
> 15:46:23 java.lang.RuntimeException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /backpressure/topologytest-22ffcfa0-8992-4258-b8b6-52346a129b58-1-0
> 15:46:23 	at backtype.storm.util$wrap_in_runtime.invoke(util.clj:52) ~[classes/:?]
> 15:46:23 	at backtype.storm.zookeeper$get_children.invoke(zookeeper.clj:168) ~[classes/:?]
> 15:46:23 	at backtype.storm.cluster_state.zookeeper_state_factory$_mkState$reify__4184.get_children(zookeeper_state_factory.clj:129) ~[classes/:?]
> 15:46:23 	at sun.reflect.GeneratedMethodAccessor53.invoke(Unknown Source) ~[?:?]
> 15:46:23 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_60]
> 15:46:23 	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_60]
> 15:46:23 	at clojure.lang.Reflector.invokeMatchingMethod(Reflector.java:93) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at clojure.lang.Reflector.invokeInstanceMethod(Reflector.java:28) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at backtype.storm.cluster$mk_storm_cluster_state$reify__4091.topology_backpressure(cluster.clj:407) ~[classes/:?]
> 15:46:23 	at sun.reflect.GeneratedMethodAccessor210.invoke(Unknown Source) ~[?:?]
> 15:46:23 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_60]
> 15:46:23 	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_60]
> 15:46:23 	at clojure.lang.Reflector.invokeMatchingMethod(Reflector.java:93) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at clojure.lang.Reflector.invokeInstanceMethod(Reflector.java:28) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at backtype.storm.daemon.worker$fn__6837$exec_fn__1477__auto__$reify__6839$check_throttle_changed__6910$cb__6911.doInvoke(worker.clj:704) ~[classes/:?]
> 15:46:23 	at clojure.lang.RestFn.invoke(RestFn.java:408) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at backtype.storm.cluster$issue_map_callback_BANG_.invoke(cluster.clj:183) ~[classes/:?]
> 15:46:23 	at backtype.storm.cluster$mk_storm_cluster_state$fn__4081.invoke(cluster.clj:239) ~[classes/:?]
> 15:46:23 	at backtype.storm.cluster_state.zookeeper_state_factory$_mkState$fn__4166.invoke(zookeeper_state_factory.clj:45) ~[classes/:?]
> 15:46:23 	at backtype.storm.zookeeper$mk_client$reify__2993.eventReceived(zookeeper.clj:63) ~[classes/:?]
> 15:46:23 	at org.apache.curator.framework.imps.CuratorFrameworkImpl$8.apply(CuratorFrameworkImpl.java:860) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.CuratorFrameworkImpl$8.apply(CuratorFrameworkImpl.java:853) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:92) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:297) [guava-16.0.1.jar:?]
> 15:46:23 	at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:83) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.CuratorFrameworkImpl.processEvent(CuratorFrameworkImpl.java:850) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.CuratorFrameworkImpl.access$000(CuratorFrameworkImpl.java:57) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.CuratorFrameworkImpl$1.process(CuratorFrameworkImpl.java:138) [curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.ConnectionState.process(ConnectionState.java:152) [curator-client-2.5.0.jar:?]
> 15:46:23 	at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522) [zookeeper-3.4.6.jar:3.4.6-1569965]
> 15:46:23 	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498) [zookeeper-3.4.6.jar:3.4.6-1569965]
> 15:46:23 Caused by: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /backpressure/topologytest-22ffcfa0-8992-4258-b8b6-52346a129b58-1-0
> 15:46:23 	at org.apache.zookeeper.KeeperException.create(KeeperException.java:111) ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> 15:46:23 	at org.apache.zookeeper.KeeperException.create(KeeperException.java:51) ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> 15:46:23 	at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1590) ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> 15:46:23 	at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1625) ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> 15:46:23 	at org.apache.curator.framework.imps.GetChildrenBuilderImpl$3.call(GetChildrenBuilderImpl.java:210) ~[curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.GetChildrenBuilderImpl$3.call(GetChildrenBuilderImpl.java:203) ~[curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:107) ~[curator-client-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.GetChildrenBuilderImpl.pathInForeground(GetChildrenBuilderImpl.java:199) ~[curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.GetChildrenBuilderImpl.forPath(GetChildrenBuilderImpl.java:191) ~[curator-framework-2.5.0.jar:?]
> 15:46:23 	at org.apache.curator.framework.imps.GetChildrenBuilderImpl.forPath(GetChildrenBuilderImpl.java:38) ~[curator-framework-2.5.0.jar:?]
> 15:46:23 	at sun.reflect.GeneratedMethodAccessor93.invoke(Unknown Source) ~[?:?]
> 15:46:23 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_60]
> 15:46:23 	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_60]
> 15:46:23 	at clojure.lang.Reflector.invokeMatchingMethod(Reflector.java:93) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at clojure.lang.Reflector.invokeInstanceMethod(Reflector.java:28) ~[clojure-1.6.0.jar:?]
> 15:46:23 	at backtype.storm.zookeeper$get_children.invoke(zookeeper.clj:166) ~[classes/:?]
> 15:46:23 	... 29 more
> {panel}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)