You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by pdxrunner <gi...@git.apache.org> on 2016/02/17 22:40:25 UTC

[GitHub] incubator-geode pull request: Feature/geode 855

GitHub user pdxrunner opened a pull request:

    https://github.com/apache/incubator-geode/pull/97

    Feature/geode 855

    GEODE-855: New test class for com.gemstone.gemfire.internal.offheap.Fragment to give complete unit test coverage of the class.
    
    Testing
    ---------
    precheckin completed with no errors

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-855

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit dd99d2d2100ee3b133d858672470829fe90e8519
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-01-26T22:11:16Z

    GEODE-855: Create unit test class for Fragment class

commit 4e219f652cc28fc6d7ba09206eaf577ae5e31418
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-01-28T23:48:22Z

    GEODE-855: Adding more unit tests for Fragment class

commit 8b775afe4efd6e171ed0253dfe05e7f95575da2e
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-02-02T19:27:30Z

    GEODE-855: more unit tests for complete coverage of Fragment class

commit 70e52ad0e4a0c19a7267c6a744e6dff49436ee4d
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-02-03T16:49:58Z

    GEODE-855: Checking system property in unit test

commit 7bb94a9d6ed196090b5cfe616eecc18469530f79
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-02-16T17:28:24Z

    GEODE-855: Refacotring in SimpleMemoryAllocatorImpl to allow resetting
    the singleton allocator for testing. Updated tests to use the memory
    allocator reset capability.

commit aeb08945a952e8cbe6f82489a720732dc2628449
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-02-17T21:24:22Z

    Revert "GEODE-855: Refacotring in SimpleMemoryAllocatorImpl to allow resetting"
    
    This reverts commit 7bb94a9d6ed196090b5cfe616eecc18469530f79.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Feature/geode 855

Posted by pdxrunner <gi...@git.apache.org>.
Github user pdxrunner closed the pull request at:

    https://github.com/apache/incubator-geode/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Feature/geode 855

Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the pull request:

    https://github.com/apache/incubator-geode/pull/97#issuecomment-185480218
  
    I pulled it in with this commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/45693879
    but I forgot to mark it closed in the commit comment.
    Ken can you go ahead and close this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Feature/geode 855

Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the pull request:

    https://github.com/apache/incubator-geode/pull/97#issuecomment-185470092
  
    This looks good. I'll pull it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Feature/geode 855

Posted by pdxrunner <gi...@git.apache.org>.
Github user pdxrunner commented on the pull request:

    https://github.com/apache/incubator-geode/pull/97#issuecomment-185765507
  
    Closing the PR per the preceding comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---