You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/12/06 21:13:01 UTC

[GitHub] [calcite] julianhyde commented on pull request #2980: [CALCITE-5389] Add STARTS_WITH() and ENDS_WITH() for BIG_QUERY

julianhyde commented on PR #2980:
URL: https://github.com/apache/calcite/pull/2980#issuecomment-1340012823

   I'm reviewing now (as of 8b92384761).
   
   I saw you merged with main. Best not to do that - or to squash/rebase. Just append commits, and you or the reviewer can squash/rebase after the reviews are done.
   
   Also best to create a new branch for each PR. My personal preference is to start with the bug number, e.g. 5389-starts-with. Then you can use tab-completion in the shell to complete 'git fetch'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org