You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "uhliarik (via GitHub)" <gi...@apache.org> on 2023/02/01 18:34:36 UTC
[GitHub] [apr] uhliarik opened a new pull request, #39: Don't force IPv6 use
uhliarik opened a new pull request, #39:
URL: https://github.com/apache/apr/pull/39
Code in apr_memcache.c is forcing to use IPv6 by setting protocol family to APR_INET instead of APR_UNSPEC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] uhliarik commented on a diff in pull request #39: Don't force IPv4 use
Posted by "uhliarik (via GitHub)" <gi...@apache.org>.
uhliarik commented on code in PR #39:
URL: https://github.com/apache/apr/pull/39#discussion_r1095715926
##########
memcache/apr_memcache.c:
##########
@@ -328,7 +328,7 @@ mc_conn_construct(void **conn_, void *params, apr_pool_t *pool)
apr_pool_t *tp;
apr_memcache_server_t *ms = params;
#if APR_HAVE_SOCKADDR_UN
- apr_int32_t family = ms->host[0] != '/' ? APR_INET : APR_UNIX;
+ apr_int32_t family = ms->host[0] != '/' ? APR_UNSPEC : APR_UNIX;
#else
apr_int32_t family = APR_INET;
Review Comment:
It definitely should!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] asfgit closed pull request #39: Don't force IPv4 use
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #39: Don't force IPv4 use
URL: https://github.com/apache/apr/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] notroj commented on pull request #39: Don't force IPv4 use
Posted by "notroj (via GitHub)" <gi...@apache.org>.
notroj commented on PR #39:
URL: https://github.com/apache/apr/pull/39#issuecomment-1416008746
Thanks @uhliarik !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] notroj commented on a diff in pull request #39: Don't force IPv4 use
Posted by "notroj (via GitHub)" <gi...@apache.org>.
notroj commented on code in PR #39:
URL: https://github.com/apache/apr/pull/39#discussion_r1094223656
##########
memcache/apr_memcache.c:
##########
@@ -328,7 +328,7 @@ mc_conn_construct(void **conn_, void *params, apr_pool_t *pool)
apr_pool_t *tp;
apr_memcache_server_t *ms = params;
#if APR_HAVE_SOCKADDR_UN
- apr_int32_t family = ms->host[0] != '/' ? APR_INET : APR_UNIX;
+ apr_int32_t family = ms->host[0] != '/' ? APR_UNSPEC : APR_UNIX;
#else
apr_int32_t family = APR_INET;
Review Comment:
Shouldn't the family = APR_INET lines change in both places too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org