You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/05/17 16:30:26 UTC

[GitHub] ivankelly opened a new pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

ivankelly opened a new pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength
URL: https://github.com/apache/incubator-pulsar/pull/1799
 
 
   LedgerEntry#getLength() returns the length of the ledger up to and
   including the length of the entry, not the length of the entry as you
   would expected (and the documentation states). So we shouldn't use it
   when serializing the entry, because what we need is the length of the
   entry.
   
   This patch changes BlockAwareSegmentInputStreamImpl to use the
   readable bytes of the bytebuf instead.
   
   Master Issue: #1511
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services