[GitHub] jt2594838 commented on a change in pull request #81: [IOTDB-31] add props of a time series declarison into FileNodeProcessor

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #81: [IOTDB-31] add props of a time series declarison into FileNodeProcessor
URL: https://github.com/apache/incubator-iotdb/pull/81#discussion_r261461746
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
 ##########
 @@ -370,18 +373,36 @@ private void analyzeMetadataCreate(AstNode astNode) throws MetadataArgsErrorExce
     AstNode paramNode = astNode.getChild(1);
     String dataType = paramNode.getChild(0).getChild(0).getText();
     String encodingType = paramNode.getChild(1).getChild(0).getText();
+    String compressor;
+    int offset = 2;
+    if (paramNode.getChildren().size() > offset) {
+      compressor = paramNode.getChild(2).getChild(0).getText();
+      offset++;
+    } else {
+      compressor = TSFileConfig.compressor;
+    }
     checkMetadataArgs(dataType, encodingType);
-    String[] paramStrings = new String[paramNode.getChildCount() - 2];
+    String[] paramStrings = new String[paramNode.getChildCount() - offset];
+    Map<String, String> props = new HashMap<>(paramStrings.length + 1, 1);
+    String[] kv;
+    for (String param : paramStrings) {
 
 Review comment:
   When is the content of `paramStrings` modified. I could only see the initialization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services