[GitHub] [daffodil] jadams-tresys commented on a diff in pull request #931: Fix issue with groups containing choices: WIP

["jadams-tresys (via GitHub)" <gi...@apache.org>]

jadams-tresys commented on code in PR #931:
URL: https://github.com/apache/daffodil/pull/931#discussion_r1108528856


##########
daffodil-test/src/test/scala/org/apache/daffodil/section15/choice_groups/TestChoice.scala:
##########
@@ -38,103 +38,103 @@ class TestChoice {
 
   import TestChoice._
 
-  @Test def test_choice_noBranch (): Unit = { runnerCH.runOneTest("choice_noBranch") }
-
-  @Test def test_optionalChoice01(): Unit = { runnerCH.runOneTest("optionalChoice01") }
-  @Test def test_optionalChoice02(): Unit = { runnerCH.runOneTest("optionalChoice02") }
-  @Test def test_optionalChoice03(): Unit = { runnerCH.runOneTest("optionalChoice03") }
-  @Test def test_optionalChoice04(): Unit = { runnerCH.runOneTest("optionalChoice04") }
-  @Test def test_optionalChoice05(): Unit = { runnerCH.runOneTest("optionalChoice05") }
-
-  @Test def test_choiceOfGroupRefs(): Unit = { runnerCH.runOneTest("choiceOfGroupRefs") }
-
-  @Test def test_basic(): Unit = { runnerCH.runOneTest("basic") }
-  @Test def test_choice2(): Unit = { runnerCH.runOneTest("choice2") }
-  @Test def test_choice3(): Unit = { runnerCH.runOneTest("choice3") }
-  @Test def test_choice4(): Unit = { runnerCH.runOneTest("choice4") }
-
-  @Test def test_choiceWithInitsAndTermsInt(): Unit = { runnerCH.runOneTest("choiceWithInitsAndTermsInt") }
-  @Test def test_choiceWithInitsAndTermsStr(): Unit = { runnerCH.runOneTest("choiceWithInitsAndTermsStr") }
-  @Test def test_choiceWithInitsAndTermsError(): Unit = { runnerCH.runOneTest("choiceWithInitsAndTermsError") }
-  @Test def test_choiceWithInitsAndTermsSeqInt(): Unit = { runnerCH.runOneTest("choiceWithInitsAndTermsSeqInt") }
-  @Test def test_choiceWithInitsAndTermsSeqStr(): Unit = { runnerCH.runOneTest("choiceWithInitsAndTermsSeqStr") }
-  @Test def test_nestedChoiceWithInitsAndTermsNestedInt(): Unit = { runnerCH.runOneTest("nestedChoiceWithInitsAndTermsNestedInt") }
-  @Test def test_nestedChoiceWithInitsAndTermsNestedStr(): Unit = { runnerCH.runOneTest("nestedChoiceWithInitsAndTermsNestedStr") }
-  @Test def test_nestedChoiceWithInitsAndTermsInt(): Unit = { runnerCH.runOneTest("nestedChoiceWithInitsAndTermsInt") }
-
-  @Test def test_choiceWithSequence1(): Unit = { runnerCH.runOneTest("choiceWithSequence1") }
-  @Test def test_choiceWithSequence2(): Unit = { runnerCH.runOneTest("choiceWithSequence2") }
-  @Test def test_choiceWithChoiceInt(): Unit = { runnerCH.runOneTest("choiceWithChoiceInt") }
-  @Test def test_choiceWithChoiceFloat(): Unit = { runnerCH.runOneTest("choiceWithChoiceFloat") }
-  @Test def test_choiceWithChoiceString(): Unit = { runnerCH.runOneTest("choiceWithChoiceString") }
-  @Test def test_choiceWithArrayInts(): Unit = { runnerCH.runOneTest("choiceWithArrayInts") }
-  @Test def test_choiceWithArrayFloats(): Unit = { runnerCH.runOneTest("choiceWithArrayFloats") }
-  @Test def test_choiceWithArrayString(): Unit = { runnerCH.runOneTest("choiceWithChoiceString") }
-
-  @Test def test_choice5(): Unit = { runnerCH.runOneTest("choice5") }
-  @Test def test_choice6(): Unit = { runnerCH.runOneTest("choice6") }
-  @Test def test_choiceFail1(): Unit = { runnerCH.runOneTest("choiceFail1") }
-  @Test def test_choiceDelim1(): Unit = { runnerCH.runOneTest("choiceDelim1") }
-  @Test def test_choiceDelim2(): Unit = { runnerCH.runOneTest("choiceDelim2") }
-  @Test def test_choiceDelimFloat(): Unit = { runnerCH.runOneTest("choiceDelimFloat") }
-  @Test def test_choiceDelimString(): Unit = { runnerCH.runOneTest("choiceDelimString") }
-  @Test def test_choiceDelimStringwSp(): Unit = { runnerCH.runOneTest("choiceDelimStringwSp") }
-  @Test def test_choiceDelimInt(): Unit = { runnerCH.runOneTest("choiceDelimInt") }
-
-  @Test def test_nestedChoice1(): Unit = { runnerCH.runOneTest("nestedChoice1") }
-
-  @Test def test_nestedChoiceAllString(): Unit = { runnerCH.runOneTest("nestedChoiceAllString") }
-  @Test def test_nestedChoiceAllFloat(): Unit = { runnerCH.runOneTest("nestedChoiceAllFloat") }
-  @Test def test_nestedChoiceAllInt(): Unit = { runnerCH.runOneTest("nestedChoiceAllInt") }
-
-  @Test def test_choiceInSequenceWithSeparators1(): Unit = { runnerCH.runOneTest("choiceInSequenceWithSeparators1") }
-  @Test def test_choiceInSequenceWithSeparators2(): Unit = { runnerCH.runOneTest("choiceInSequenceWithSeparators2") }
-
-  @Test def test_sequenceInChoiceInSequenceWithSeparators1(): Unit = { runnerCH.runOneTest("sequenceInChoiceInSequenceWithSeparators1") }
-  @Test def test_sequenceInChoiceInSequenceWithSeparators2(): Unit = { runnerCH.runOneTest("sequenceInChoiceInSequenceWithSeparators2") }
-  @Test def test_sequenceInChoiceInSequenceWithSameSeparators1(): Unit = { runnerCH.runOneTest("sequenceInChoiceInSequenceWithSameSeparators1") }
-  @Test def test_sequenceInChoiceInSequenceWithSameSeparators2(): Unit = { runnerCH.runOneTest("sequenceInChoiceInSequenceWithSameSeparators2") }
-
-  @Test def test_choice_minOccurs(): Unit = { runnerCH.runOneTest("choice_minOccurs") }
-  @Test def test_choice_maxOccurs(): Unit = { runnerCH.runOneTest("choice_maxOccurs") }
-
-  @Test def test_choice_with_inputvaluecalc(): Unit = { runnerCH.runOneTest("choice_with_inputvaluecalc") }
-
-  // DFDL-641
-  @Test def test_direct_dispatch_01(): Unit = { runnerCH.runOneTest("direct_dispatch_01") }
-  @Test def test_direct_dispatch_02(): Unit = { runnerCH.runOneTest("direct_dispatch_02") }
-  @Test def test_direct_dispatch_03(): Unit = { runnerCH.runOneTest("direct_dispatch_03") }
-  @Test def test_direct_dispatch_04(): Unit = { runnerCH.runOneTest("direct_dispatch_04") }
-  @Test def test_direct_dispatch_05(): Unit = { runnerCH.runOneTest("direct_dispatch_05") }
-  @Test def test_direct_dispatch_06(): Unit = { runnerCH.runOneTest("direct_dispatch_06") }
-  @Test def test_direct_dispatch_07(): Unit = { runnerCH.runOneTest("direct_dispatch_07") }
-  @Test def test_direct_dispatch_08(): Unit = { runnerCH.runOneTest("direct_dispatch_08") }
-  @Test def test_direct_dispatch_09(): Unit = { runnerCH.runOneTest("direct_dispatch_09") }
-  @Test def test_direct_dispatch_10(): Unit = { runnerCH.runOneTest("direct_dispatch_10") }
-  @Test def test_direct_dispatch_11(): Unit = { runnerCH.runOneTest("direct_dispatch_11") }
-  @Test def test_direct_dispatch_12(): Unit = { runnerCH.runOneTest("direct_dispatch_12") }
-  @Test def test_direct_dispatch_13(): Unit = { runnerCH.runOneTest("direct_dispatch_13") }
-  @Test def test_direct_dispatch_14(): Unit = { runnerCH.runOneTest("direct_dispatch_14") }
-  @Test def test_direct_dispatch_15(): Unit = { runnerCH.runOneTest("direct_dispatch_15") }
-  @Test def test_direct_dispatch_16(): Unit = { runnerCH.runOneTest("direct_dispatch_16") }
-  @Test def test_direct_dispatch_17(): Unit = { runnerCH.runOneTest("direct_dispatch_17") }
-
-  // DAFFODIL-2562
+  //@Test def test_choice_noBranch (): Unit = { runnerCH.runOneTest("choice_noBranch") }

Review Comment:
   More like I forgot that pushing up a commit would automatically update this pull request.  My machine had been acting up so I wanted to push things up to my branch for safe keeping, just forgot it would update this pull request.  I think I might actually delete this now that I have a better understanding of what the problem is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org