[GitHub] [zookeeper] eolivelli commented on a change in pull request #1171: ZOOKEEPER-2083 Remove deprecated class AuthFastLeaderElection

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1171: ZOOKEEPER-2083 Remove deprecated class AuthFastLeaderElection
URL: https://github.com/apache/zookeeper/pull/1171#discussion_r363741456
 
 

 ##########
 File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
 ##########
 @@ -1021,9 +1021,16 @@ of servers -- that is, when deploying clusters of servers.
 
 * *electionAlg* :
     (No Java system property)
-    Election implementation to use. Default value is "3" 
-    which corresponds to TCP-based version of
-    fast leader election.
+    Election implementation to use. A value of "1" corresponds to the
+    non-authenticated UDP-based version of fast leader election, "2"
+    corresponds to the authenticated UDP-based version of fast
+    leader election, and "3" corresponds to TCP-based version of
+    fast leader election. Algorithm 3 was made default in 3.2.0 and 
+    prior versions (3.0.0 and 3.1.0) were using algorithm 1 and 2 as well.
+    ###### Note
+    >The implementations of leader election 1, and 2 were 
+    **deprecated** in 3.4.0. We will be removing them in release of 3.6.0, 
 
 Review comment:
   What about:
   `Since 3.6.0 only FastLeaderElection is available, in case of upgrade you have to shutdown all of your servers and restart them with electionAlg=3 (or removing the line from the configuration file)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services