[GitHub] [phoenix-connectors] richardantal commented on a diff in pull request #101: PHOENIX-6937 Remove the connectors for Phoenix 4.x

["richardantal (via GitHub)" <gi...@apache.org>]

richardantal commented on code in PR #101:
URL: https://github.com/apache/phoenix-connectors/pull/101#discussion_r1194822987


##########
phoenix5-spark3/src/main/java/org/apache/phoenix/spark/sql/connector/reader/PhoenixDataSourceReadOptions.java:
##########
@@ -34,7 +34,7 @@ class PhoenixDataSourceReadOptions implements Serializable {
     PhoenixDataSourceReadOptions(String zkUrl, String scn, String tenantId,
                                  String selectStatement, Properties overriddenProps,
         byte[] pTableCacheBytes) {
-        if(overriddenProps == null){
+        if (overriddenProps == null) {

Review Comment:
   Sure, I removed the checkstyle related fixes, I will do it in a next round.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org