You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/11 14:43:55 UTC

[GitHub] [flink-statefun] igalshilman opened a new pull request #274: [FLINK-22533] Add custom metrics

igalshilman opened a new pull request #274:
URL: https://github.com/apache/flink-statefun/pull/274


   ### This PR introduces custom metrics to the embedded SDK.
   
   
   ```java
   public interface FunctionTypeScopedMetrics {
   
     /**
      * Retrieves (or creates) a counter metric with this name.
      *
      * @param name a metric name
      * @return a counter.
      */
     Counter counter(String name);
   }
   ```
   
   And
   
   ```java
   public interface RouterMetrics {
   
     /**
      * Gets (or creates) a Counter with the given name.
      *
      * @param name the counter name
      * @return a counter
      */
     Counter counter(String name);
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] sjwiesman commented on pull request #274: [FLINK-22533] Add custom metrics

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #274:
URL: https://github.com/apache/flink-statefun/pull/274#issuecomment-940558983


   The general implementation looks good.
   
   My only comment is on the API. It feels strange to me that we have `FunctionTypeScopedMetrics` and `RouterMetrics` as two separate interfaces. Could we unify them into one interface? 
   
   I also really like the cleanup of `LocalFunctionGroup`, that whole part of the codebase is much easier to follow :) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] igalshilman merged pull request #274: [FLINK-22533] Add custom metrics

Posted by GitBox <gi...@apache.org>.
igalshilman merged pull request #274:
URL: https://github.com/apache/flink-statefun/pull/274


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] igalshilman commented on pull request #274: [FLINK-22533] Add custom metrics

Posted by GitBox <gi...@apache.org>.
igalshilman commented on pull request #274:
URL: https://github.com/apache/flink-statefun/pull/274#issuecomment-940813120


   Thanks for the review @sjwiesman.
   And I think that you are right, we don't need a separate interface. As what unifies them is that these are user defined metrics.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org