You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/16 21:33:13 UTC

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #4170: xtensa/esp32: Make output readable and rmv unnecessary var.

saramonteiro opened a new pull request #4170:
URL: https://github.com/apache/incubator-nuttx/pull/4170


   ## Summary 
   
   This MR:
   - Makes the output readable because the gpio example reads the output.
   - Remove unnecessary variable that could be replaced by the loop index.
   
   ## Impact
   
   Now gpio example runs and verify value is really representing the value of the output.
   
   
   ## Testing
   
   Using gpio example.
   
   Before:
   ```
   nsh> gpio -o 1 /dev/gpout0
   Driver: /dev/gpout0
     Output pin:    Value=0
     Writing:       Value=1
     Verify:        Value=0
   ```
   
   After:
   
   ```
   nsh> gpio -o 1 /dev/gpout0
   Driver: /dev/gpout0
     Output pin:    Value=0
     Writing:       Value=1
     Verify:        Value=1
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis merged pull request #4170: xtensa/esp32: Make output readable and rmv unnecessary var.

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #4170:
URL: https://github.com/apache/incubator-nuttx/pull/4170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org