You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/04 18:33:45 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4039: Update to arrow 26, change timezones

alamb commented on code in PR #4039:
URL: https://github.com/apache/arrow-datafusion/pull/4039#discussion_r1014343117


##########
datafusion/optimizer/tests/integration-test.rs:
##########
@@ -237,25 +235,26 @@ fn timestamp_nano_ts_none_predicates() -> Result<()> {
     // a scan should have the now()... predicate folded to a single
     // constant and compared to the column without a cast so it can be
     // pushed down / pruned
-    let expected = "Projection: test.col_int32\n  Filter: test.col_ts_nano_utc < TimestampNanosecond(1666612093000000000, Some(\"UTC\"))\
-                    \n    TableScan: test projection=[col_int32, col_ts_nano_none]";
+    let expected =

Review Comment:
   Turns out this also fixes https://github.com/apache/arrow-datafusion/issues/3938 🎉 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org