You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/05/07 20:28:00 UTC

[GitHub] couchdb pull request: Fauxton: use .listenTo and not .on

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/226

    Fauxton: use .listenTo and not .on

    There was no `.off` call on destroy, so these two Eventhandlers
    where leaking memory

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb on-to-listenTo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
    
----
commit ebade0f2f82d4da60e386f4aeaf24ecb98181e81
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-05-07T18:22:36Z

    Fauxton: use .listenTo and not .on
    
    There was no `.off` call on destroy, so these two Eventhandlers
    where leaking memory

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: use .listenTo and not .on

Posted by deathbearbrown <gi...@git.apache.org>.

Github user deathbearbrown commented on the pull request:

    https://github.com/apache/couchdb/pull/226#issuecomment-42547835
  
    +1 <3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: use .listenTo and not .on

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb/pull/226


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: use .listenTo and not .on

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/226#issuecomment-42581081
  
    yay! merged as ebade0f2f82d4da60e386f4aeaf24ecb98181e81


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: use .listenTo and not .on

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb/pull/226#issuecomment-42523659
  
    Great spot. Merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---