You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Milos Kleint (JIRA)" <ji...@codehaus.org> on 2006/11/07 14:19:31 UTC
[jira] Created: (MANTLR-12) setting custom security manager might
fail in embedded environment
setting custom security manager might fail in embedded environment
------------------------------------------------------------------
Key: MANTLR-12
URL: http://jira.codehaus.org/browse/MANTLR-12
Project: Maven 2.x Antlr Plugin
Issue Type: Bug
Reporter: Milos Kleint
when the antlr plugin is run in embedded environment, eg. in netbeans IDE integration, it cannot be taken for granted that the setting of new security manager will succeed.
[antlr:generate {execution: default}]
[INFO]grammar: /space/src/hudson/main/core/src/main/grammar/crontab.g
[INFO]------------------------------------------------------------------------
[ERROR]FATAL ERROR
[INFO]------------------------------------------------------------------------
[INFO]null
[INFO]------------------------------------------------------------------------
[INFO]Trace
java.lang.SecurityException
at org.netbeans.TopSecurityManager.checkSetSecurityManager(TopSecurityManager.java:351)
at org.netbeans.TopSecurityManager.checkPermission(TopSecurityManager.java:315)
at java.lang.System.setSecurityManager0(System.java:273)
at java.lang.System.setSecurityManager(System.java:264)
at org.apache.maven.plugin.antlr.AntlrPlugin.execute(AntlrPlugin.java:99)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:417)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:610)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:551)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:530)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:309)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:276)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:393)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:182)
at org.apache.maven.embedder.MavenEmbedder.execute(MavenEmbedder.java:760)
at org.codehaus.mevenide.netbeans.execute.MavenJavaExecutor.run(MavenJavaExecutor.java:257)
at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:129)
[INFO]------------------------------------------------------------------------
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MANTLR-12) setting custom security manager might
fail in embedded environment
Posted by "Milos Kleint (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MANTLR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milos Kleint closed MANTLR-12.
------------------------------
Resolution: Fixed
fixed the patch and applied.
http://svn.apache.org/viewvc?view=rev&revision=519623
Still not a generic solution but fixes the problem in netbeans. The only generic solution I can see is rewrite to external VM execution.
> setting custom security manager might fail in embedded environment
> ------------------------------------------------------------------
>
> Key: MANTLR-12
> URL: http://jira.codehaus.org/browse/MANTLR-12
> Project: Maven 2.x Antlr Plugin
> Issue Type: Bug
> Reporter: Milos Kleint
> Attachments: ANTLR-12.patch
>
>
> when the antlr plugin is run in embedded environment, eg. in netbeans IDE integration, it cannot be taken for granted that the setting of new security manager will succeed.
> [antlr:generate {execution: default}]
> [INFO]grammar: /space/src/hudson/main/core/src/main/grammar/crontab.g
> [INFO]------------------------------------------------------------------------
> [ERROR]FATAL ERROR
> [INFO]------------------------------------------------------------------------
> [INFO]null
> [INFO]------------------------------------------------------------------------
> [INFO]Trace
> java.lang.SecurityException
> at org.netbeans.TopSecurityManager.checkSetSecurityManager(TopSecurityManager.java:351)
> at org.netbeans.TopSecurityManager.checkPermission(TopSecurityManager.java:315)
> at java.lang.System.setSecurityManager0(System.java:273)
> at java.lang.System.setSecurityManager(System.java:264)
> at org.apache.maven.plugin.antlr.AntlrPlugin.execute(AntlrPlugin.java:99)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:417)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:610)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:551)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:530)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:309)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:276)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:393)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:182)
> at org.apache.maven.embedder.MavenEmbedder.execute(MavenEmbedder.java:760)
> at org.codehaus.mevenide.netbeans.execute.MavenJavaExecutor.run(MavenJavaExecutor.java:257)
> at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:129)
> [INFO]------------------------------------------------------------------------
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MANTLR-12) setting custom security manager might
fail in embedded environment
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MANTLR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90265 ]
Jason van Zyl commented on MANTLR-12:
-------------------------------------
This patch doesn't work for me with a clean checkout and applying. I get an error with the security manager.
> setting custom security manager might fail in embedded environment
> ------------------------------------------------------------------
>
> Key: MANTLR-12
> URL: http://jira.codehaus.org/browse/MANTLR-12
> Project: Maven 2.x Antlr Plugin
> Issue Type: Bug
> Reporter: Milos Kleint
> Attachments: ANTLR-12.patch
>
>
> when the antlr plugin is run in embedded environment, eg. in netbeans IDE integration, it cannot be taken for granted that the setting of new security manager will succeed.
> [antlr:generate {execution: default}]
> [INFO]grammar: /space/src/hudson/main/core/src/main/grammar/crontab.g
> [INFO]------------------------------------------------------------------------
> [ERROR]FATAL ERROR
> [INFO]------------------------------------------------------------------------
> [INFO]null
> [INFO]------------------------------------------------------------------------
> [INFO]Trace
> java.lang.SecurityException
> at org.netbeans.TopSecurityManager.checkSetSecurityManager(TopSecurityManager.java:351)
> at org.netbeans.TopSecurityManager.checkPermission(TopSecurityManager.java:315)
> at java.lang.System.setSecurityManager0(System.java:273)
> at java.lang.System.setSecurityManager(System.java:264)
> at org.apache.maven.plugin.antlr.AntlrPlugin.execute(AntlrPlugin.java:99)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:417)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:610)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:551)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:530)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:309)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:276)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:393)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:182)
> at org.apache.maven.embedder.MavenEmbedder.execute(MavenEmbedder.java:760)
> at org.codehaus.mevenide.netbeans.execute.MavenJavaExecutor.run(MavenJavaExecutor.java:257)
> at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:129)
> [INFO]------------------------------------------------------------------------
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MANTLR-12) setting custom security manager might
fail in embedded environment
Posted by "Milos Kleint (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MANTLR-12?page=all ]
Milos Kleint updated MANTLR-12:
-------------------------------
Attachment: ANTLR-12.patch
here's a suggested patch.
the security manager is still set, but when failing to set it, assume the current manager will be able to cope with System.exit().
had to handle the error messaging differently because sometimes the hints from the custom SM are not available.
a rather complex solution to the problem would be to execute antlr externally, like the ant task is doing..
> setting custom security manager might fail in embedded environment
> ------------------------------------------------------------------
>
> Key: MANTLR-12
> URL: http://jira.codehaus.org/browse/MANTLR-12
> Project: Maven 2.x Antlr Plugin
> Issue Type: Bug
> Reporter: Milos Kleint
> Attachments: ANTLR-12.patch
>
>
> when the antlr plugin is run in embedded environment, eg. in netbeans IDE integration, it cannot be taken for granted that the setting of new security manager will succeed.
> [antlr:generate {execution: default}]
> [INFO]grammar: /space/src/hudson/main/core/src/main/grammar/crontab.g
> [INFO]------------------------------------------------------------------------
> [ERROR]FATAL ERROR
> [INFO]------------------------------------------------------------------------
> [INFO]null
> [INFO]------------------------------------------------------------------------
> [INFO]Trace
> java.lang.SecurityException
> at org.netbeans.TopSecurityManager.checkSetSecurityManager(TopSecurityManager.java:351)
> at org.netbeans.TopSecurityManager.checkPermission(TopSecurityManager.java:315)
> at java.lang.System.setSecurityManager0(System.java:273)
> at java.lang.System.setSecurityManager(System.java:264)
> at org.apache.maven.plugin.antlr.AntlrPlugin.execute(AntlrPlugin.java:99)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:417)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:610)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:551)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:530)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:309)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:276)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:393)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:182)
> at org.apache.maven.embedder.MavenEmbedder.execute(MavenEmbedder.java:760)
> at org.codehaus.mevenide.netbeans.execute.MavenJavaExecutor.run(MavenJavaExecutor.java:257)
> at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:129)
> [INFO]------------------------------------------------------------------------
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira