You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/01/29 12:42:14 UTC
[GitHub] incubator-brooklyn pull request: Transformer clean-up and catalogI...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/487
Transformer clean-up and catalogItemId
Transformer code uses simpler XSLT, cleaner java, and supports causing a `catalogItemId` change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn transformer-share-xslt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #487
----
commit 25d8dc309d038437a50b4cbd64fdf66968235fd4
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-01-28T12:25:00Z
add some low-level xslt compound transformer rules
this will allow refactoring and simplifying the existing mechanisms, and supporting new things like replacing catalogItemId
commit 5e1d94e936e5303d92366de7b4fa24a0801092e0
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-01-28T12:51:07Z
switch xslt transformation to use clearer java names for the changes
commit e82c9a672ee7cdc2ae4f80d2ffc32a1152f92a63
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-01-28T17:01:55Z
add low-level transformer support for changing catalogItemId
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Transformer clean-up and catalogI...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Transformer clean-up and catalogI...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/487#issuecomment-72210783
LGTM. I like how easy it's to introduce new transforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---