[jira] [Updated] (WICKET-6063) Add support for WebSocketRequest#getUrl() and other properties which are available in the handshake request

["Martin Grigorov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-6063:
------------------------------------
    Summary: Add support for WebSocketRequest#getUrl() and other properties which are available in the handshake request  (was: Null getUrl() in WebSocketRequests can lead to IllegalArgumentExceptions)

> Add support for WebSocketRequest#getUrl() and other properties which are available in the handshake request
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-6063
>                 URL: https://issues.apache.org/jira/browse/WICKET-6063
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-native-websocket
>    Affects Versions: 6.21.0
>            Reporter: Daniel Stoch
>            Assignee: Martin Grigorov
>         Attachments: websocket-errors.zip
>
>
> During request processing some components can want to access some request parameters, paths, etc. When this is done during web socket request it can lead to IllegalArgumentExceptions, because WebSocketRequest.getUrl() method returns null.
> {code}
> java.lang.IllegalArgumentException: Argument 'url' may not be null.
>     at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
>     at
> org.apache.wicket.request.parameter.UrlRequestParametersAdapter.<init>(UrlRequestParametersAdapter.java:48)
>     at
> org.apache.wicket.request.Request.getQueryParameters(Request.java:128)
>     at
> org.apache.wicket.request.Request.getRequestParameters(Request.java:136)
> {code}
> Maybe these methods should better return empty Url instead of null (
> return new Url(); )?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)