You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/27 00:57:32 UTC

[GitHub] [geode] dschneider-pivotal opened a new pull request #5320: Refactor inregion classes

dschneider-pivotal opened a new pull request #5320:
URL: https://github.com/apache/geode/pull/5320


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal merged pull request #5320: GEODE-8332: Refactor inregion classes

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5320:
URL: https://github.com/apache/geode/pull/5320


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #5320: Refactor inregion classes

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on pull request #5320:
URL: https://github.com/apache/geode/pull/5320#issuecomment-651221442


   The dunit failure is the know issue: https://issues.apache.org/jira/browse/GEODE-8110 and unrelated to this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5320: Refactor inregion classes

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5320:
URL: https://github.com/apache/geode/pull/5320#discussion_r450315786



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/SingleResultRedisFunction.java
##########
@@ -64,11 +61,4 @@ public boolean optimizeForWrite() {
   public boolean isHA() {
     return true;
   }
-
-  public static void computeWithPrimaryLocked(Object key, LocalDataSet localDataSet, Runnable r) {

Review comment:
       Yes. If, in the future, we have an operation that needs the LocalDataSet then we can pass it to that operation explicitly.
   I moved RenameFunction.getLocalDataSet




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5320: Refactor inregion classes

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5320:
URL: https://github.com/apache/geode/pull/5320#discussion_r450252573



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/SingleResultRedisFunction.java
##########
@@ -64,11 +61,4 @@ public boolean optimizeForWrite() {
   public boolean isHA() {
     return true;
   }
-
-  public static void computeWithPrimaryLocked(Object key, LocalDataSet localDataSet, Runnable r) {

Review comment:
       I presume it's OK that we're not using the `LocalDataSet` anymore? On a related note `RenameFunction.getLocalDatSet` can be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org