You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/11 03:33:47 UTC
[GitHub] [incubator-kvrocks] usrtax opened a new pull request, #850: kvrocks docker can use environment variables define config
usrtax opened a new pull request, #850:
URL: https://github.com/apache/incubator-kvrocks/pull/850
fix https://github.com/apache/incubator-kvrocks/discussions/848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #850: kvrocks docker can use environment variables define config
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #850:
URL: https://github.com/apache/incubator-kvrocks/pull/850#issuecomment-1242899313
@tanruixiang I suggest we focus on the design decision before jump into implementation details.
@PragmaTwice @git-hulk @ShooterIT @usrtax a quick idea on passing override from environment variable is taking a namespace said `kvrocks.` and when start the server, read from the env vars and overwrite `xxx` with `kvrocks.xxx`.
Anyway, I hope this initiative goes through a design instead of rushing into patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on pull request #850: kvrocks docker can use environment variables define config
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on PR #850:
URL: https://github.com/apache/incubator-kvrocks/pull/850#issuecomment-1242898881
Hi. I find Macos does't support realpath. I have submitted a patch to you. And I feel that two `run`(`run.sh` and `_run.sh`) are a little strange. Can these two `run` be combined into one?@usrtax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #850: kvrocks docker can use environment variables define config
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #850:
URL: https://github.com/apache/incubator-kvrocks/pull/850#issuecomment-1242883159
I think, if we want to support command line options for configurations, we need to implement it in a more direct way, rather than `sed`, which is more like a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun closed pull request #850: kvrocks docker can use environment variables define config
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #850: kvrocks docker can use environment variables define config
URL: https://github.com/apache/incubator-kvrocks/pull/850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] usrtax commented on pull request #850: kvrocks docker can use environment variables define config
Posted by GitBox <gi...@apache.org>.
usrtax commented on PR #850:
URL: https://github.com/apache/incubator-kvrocks/pull/850#issuecomment-1242888707
> I think, if we want to support command line options for configurations, we need to implement it in a more direct way, rather than `sed`, which is more like a workaround.
I agree with this, but I'm not familiar with C code and don't know how to modify it.
Generally speaking, if you not using docker, there is no need to configure in this way.
I created my own version of docker [usertax/kvrocks](https://hub.docker.com/repository/docker/usertax/kvrocks) for easy to use now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #850: kvrocks docker can use environment variables define config
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #850:
URL: https://github.com/apache/incubator-kvrocks/pull/850#issuecomment-1242899423
Closed in favor of a discussion on the Discussions forum or dev@kvrocks.apache.org mailing list first. Make it clear that we don't rush into patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org