You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Arvid Heise (Jira)" <ji...@apache.org> on 2020/12/03 08:03:01 UTC
[jira] [Commented] (FLINK-16443) Fix wrong fix for user-code
CheckpointExceptions
[ https://issues.apache.org/jira/browse/FLINK-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242987#comment-17242987 ]
Arvid Heise commented on FLINK-16443:
-------------------------------------
Merged into master as 208126aa242c4e217be493140aefcf16c3c3aba9.
> Fix wrong fix for user-code CheckpointExceptions
> ------------------------------------------------
>
> Key: FLINK-16443
> URL: https://issues.apache.org/jira/browse/FLINK-16443
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Reporter: Stephan Ewen
> Assignee: Arvid Heise
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> The problem of having exceptions that are only in the user code classloader was fixed by proactively serializing them inside the {{CheckpointException}}. That means all consumers of {{CheckpointException}} now need to be aware of that and unwrap the serializable exception.
> I believe the right way to fix this would have been to use a SerializedException in the {{DeclineCheckpoint}} message instead, which would have localized the change to the actual problem: RPC transport.
> I would suggest to revert https://github.com/apache/flink/pull/9742 and instead apply the above described change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)