You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/19 23:52:36 UTC

[GitHub] [kafka] kowshik opened a new pull request #10732: MINOR: Eliminate redundant functions in LogTest suite

kowshik opened a new pull request #10732:
URL: https://github.com/apache/kafka/pull/10732


   In this PR, I have eliminated the following 6 redundant static functions in test code:
   ```
   LogTest.createLogConfig()
   LogTest.createLog()
   LogTest.hasOffsetOverflow()
   LogTest.firstOverflowSegment()
   LogTest.rawSegment()
   LogTest.initializeLogDirWithOverflowedSegment()
   ```
   
   The above ones are already defined in `LogTestUtils.scala`, so we can just reuse those instead.
   
   **Tests:**
   Relying on existing tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik commented on pull request #10732: MINOR: Eliminate redundant functions in LogTest suite

Posted by GitBox <gi...@apache.org>.

kowshik commented on pull request #10732:
URL: https://github.com/apache/kafka/pull/10732#issuecomment-844574308


   cc @junrao @satishd for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao merged pull request #10732: MINOR: Eliminate redundant functions in LogTest suite

Posted by GitBox <gi...@apache.org>.

junrao merged pull request #10732:
URL: https://github.com/apache/kafka/pull/10732


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org