You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Keith Wannamaker <Ke...@Wannamaker.org> on 2002/06/08 17:29:50 UTC
[PATCH] 1.5B / 1.6A LineContains broken
LineContains was broken in rev 1.4.2.1 in 1.5B and
in 1.6A when a 'fix' was forward-ported in rev 1.5
The problem is that LineContains will not match
adjacent lines. I would suggest the following patch
to both the 1.5 branch and head.
http://apache.org/~keith/line.txt
As an example, if your file contained:
foo1
foo2
foo3
foo4
foo5
, a linecontains of "foo" would only return
foo1
foo3
foo5
with the current code (both 1.5 and 1.6)
Thanks,
Keith
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] 1.5B / 1.6A LineContains broken
Posted by Magesh Umasankar <um...@apache.org>.
If nobody beats me to this, I will take care of this
on Monday.
Cheers,
Magesh
----- Original Message -----
From: "Keith Wannamaker" <Ke...@Wannamaker.org>
To: <an...@jakarta.apache.org>
Sent: Saturday, June 08, 2002 11:29 AM
Subject: [PATCH] 1.5B / 1.6A LineContains broken
> LineContains was broken in rev 1.4.2.1 in 1.5B and
> in 1.6A when a 'fix' was forward-ported in rev 1.5
>
> The problem is that LineContains will not match
> adjacent lines. I would suggest the following patch
> to both the 1.5 branch and head.
>
> http://apache.org/~keith/line.txt
>
> As an example, if your file contained:
> foo1
> foo2
> foo3
> foo4
> foo5
> , a linecontains of "foo" would only return
> foo1
> foo3
> foo5
> with the current code (both 1.5 and 1.6)
>
> Thanks,
> Keith
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] 1.5B / 1.6A LineContains broken
Posted by Steve Loughran <st...@iseran.com>.
do we have a test for this one, Keith?
----- Original Message -----
From: "Keith Wannamaker" <Ke...@Wannamaker.org>
To: <an...@jakarta.apache.org>
Sent: Saturday, June 08, 2002 8:29 AM
Subject: [PATCH] 1.5B / 1.6A LineContains broken
> LineContains was broken in rev 1.4.2.1 in 1.5B and
> in 1.6A when a 'fix' was forward-ported in rev 1.5
>
> The problem is that LineContains will not match
> adjacent lines. I would suggest the following patch
> to both the 1.5 branch and head.
>
> http://apache.org/~keith/line.txt
>
> As an example, if your file contained:
> foo1
> foo2
> foo3
> foo4
> foo5
> , a linecontains of "foo" would only return
> foo1
> foo3
> foo5
> with the current code (both 1.5 and 1.6)
>
> Thanks,
> Keith
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>