[GitHub] [kafka] cadonna commented on a change in pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics

[GitBox <gi...@apache.org>]

cadonna commented on a change in pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#discussion_r636167629



##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java
##########
@@ -777,12 +777,12 @@ public void testLatencyMetrics() {
         final String entity = "entity";
         final String operation = "put";
 
-        final Sensor sensor1 = streamsMetrics.addLatencyAndThroughputSensor(scope, entity, operation, RecordingLevel.DEBUG);

Review comment:
       You can also remove the `@SuppressWarnings("deprecation")` at the top of the method.

##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java
##########
@@ -797,11 +797,11 @@ public void testThroughputMetrics() {
         final String entity = "entity";
         final String operation = "put";
 
-        final Sensor sensor1 = streamsMetrics.addThroughputSensor(scope, entity, operation, RecordingLevel.DEBUG);

Review comment:
       You can also remove the `@SuppressWarnings("deprecation")` at the top of the method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org