[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

[GitBox <gi...@apache.org>]

jwfromm commented on a change in pull request #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth
URL: https://github.com/apache/incubator-tvm/pull/4271#discussion_r343818683
 
 

 ##########
 File path: python/tvm/relay/frontend/onnx.py
 ##########
 @@ -466,6 +466,76 @@ def _impl_v5(cls, inputs, attr, params):
                 static_shape.asnumpy().astype('int32')))
         return out
 
+
+class DepthToSpace(OnnxOpConverter):
+    """ Operator converter for DepthToSpace.
+    """
+
+    @classmethod
+    def _impl_v1(cls, inputs, attr, params):
 
 Review comment:
   This implementation is for the OpSet 11 definition of DepthToSpace. OpSet 1 is slightly different, for example it has no mode attribute. Please change this to impl_v11 to reflect this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services