[GitHub] [airflow] uranusjr commented on a diff in pull request #34063: Bring back SHUTDOWN-related constants

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #34063:
URL: https://github.com/apache/airflow/pull/34063#discussion_r1314614951


##########
airflow/utils/state.py:
##########
@@ -58,6 +58,13 @@ class TaskInstanceState(str, Enum):
     SKIPPED = "skipped"  # Skipped by branching or some other mechanism
     DEFERRED = "deferred"  # Deferrable operator waiting on a trigger
 
+    # Not used anymore, kept for compatibility.

Review Comment:
   Not _that_ useful since I’d assume the cleanup process would involve searching for `:meta private:` anyway. But a comment is easy and would not hurt.



##########
airflow/utils/state.py:
##########
@@ -58,6 +58,13 @@ class TaskInstanceState(str, Enum):
     SKIPPED = "skipped"  # Skipped by branching or some other mechanism
     DEFERRED = "deferred"  # Deferrable operator waiting on a trigger
 
+    # Not used anymore, kept for compatibility.

Review Comment:
   Not _that_ useful since I’d assume the cleanup process would involve searching for `:meta private:` anyway. But a comment is easy and would not hurt.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org