You are viewing a plain text version of this content. The canonical link for it is here.

Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2015/10/11 01:20:18 UTC

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

GitHub user sandhyasun opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/115

    Adding .rat-excludes, readme for rat and remove unneeded files lacking copyrights.Also hive/TEST009 fix.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sandhyasun/incubator-trafodion sandhya_copyright2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 26fe0b3a50627fd53b6db29edc0d61be88f5c5b2
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date:   2015-10-06T21:43:31Z

    Unneeded windows files

commit 2ce3fb98908abba16cdfbf79b71d74d550b4a983
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date:   2015-10-09T21:58:37Z

    Includes cleanup, rat-excludes file and rat_readme to explain exceptions.

commit f4a9bac2005d1a52011915d44bf85a77817909fe
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date:   2015-10-09T22:01:10Z

    Merge remote branch 'origin/master' into sandhya_copyright2

commit 4a34a0483e59ff4a56a07e62be42355ce7553c98
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date:   2015-10-10T23:15:35Z

    Removed unneeded files lacking copyrights
    Fixing hive/EXPECTED009, a result changed sdue to new heap sort algo.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by robertamarton <gi...@git.apache.org>.

Github user robertamarton commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/115#discussion_r41787499

--- Diff: RAT_README.txt ---
@@ -0,0 +1,68 @@
+------------------------------------------------------------------------------
+This readme contains the list of excluded files that don't have apache headers and explanations on why they don't and cannnot have headers
+To run the RAT report for Trafodion:
+1. Install Apache Rat. Taht will install the needed jar file.
+2. Use command line:
+ java -jar apache-rat-0.11.jar -E $MY_SQROOT/../../.rat-excludes -d $MY_SQROOT/../.. > <RAT output log file>
+------------------------------------------------------------------------------
+FILE : NOTES
+------------------------------------------------------------------------------
+
+
+.gitignore : File contains pattterns that GIT reads. Cannot have comments
+.rat-excludes : This file used by RAT cannot have a comment section
+package.exclude* : List of files to exclude from packaging - cannot pargse comments.
+eclipse.*project* : Eclipse related project file
+*.csv : Macro file cannot have comments.
+*/hbase-trx/hbase-protocol/* : Copied from Hbse and cannot haveApache copyrights
--- End diff --

Spelling Hbse -> HBase, haveApache -> have Apache

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by robertamarton <gi...@git.apache.org>.

Github user robertamarton commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/115#discussion_r41787360

Spelling - pargse -> parse

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by sandhyasun <gi...@git.apache.org>.

Github user sandhyasun commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/115#discussion_r41801548

Corrected typo. Rewrite the comment that was confusing about the protobuf files. Removed 2 unneeded files that had previously been copied and weren't needed.

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by sandhyasun <gi...@git.apache.org>.

Github user sandhyasun commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/115#discussion_r41801579

Done

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by robertamarton <gi...@git.apache.org>.

Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/115#discussion_r41787225
  
    --- Diff: RAT_README.txt ---
    @@ -0,0 +1,68 @@
    +------------------------------------------------------------------------------
    +This readme contains the list of excluded files that don't have apache headers and explanations on why they don't and cannnot have headers 
    +To run the RAT report for Trafodion:
    +1. Install Apache Rat. Taht will install the needed jar file. 
    +2. Use command line:
    --- End diff --
    
    Spelling - Taht -> That


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by arvind-narain <gi...@git.apache.org>.

Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/115#discussion_r41702704
  
    --- Diff: core/conn/trafci/src/org/trafodion/ci/Properties/trafciDefaultLookAndFeel.properties ---
    @@ -1,3 +1,26 @@
    +#
    --- End diff --
    
    I'll check again on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by sandhyasun <gi...@git.apache.org>.

Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/115#discussion_r41801568
  
    --- Diff: RAT_README.txt ---
    @@ -0,0 +1,68 @@
    +------------------------------------------------------------------------------
    +This readme contains the list of excluded files that don't have apache headers and explanations on why they don't and cannnot have headers 
    +To run the RAT report for Trafodion:
    +1. Install Apache Rat. Taht will install the needed jar file. 
    +2. Use command line:
    --- End diff --
    
    Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by DaveBirdsall <gi...@git.apache.org>.

Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/115#discussion_r41779455

Seems odd... if it is HBase, shouldn't it already have copyrights?

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by sandhyasun <gi...@git.apache.org>.

Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/115#discussion_r41726218
  
    --- Diff: core/conn/trafci/src/org/trafodion/ci/Properties/trafciDefaultLookAndFeel.properties ---
    @@ -1,3 +1,26 @@
    +#
    --- End diff --
    
    I think the code is working fine with the copyright. The swjdbc tests and phoenix test ran fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

Posted by arvind-narain <gi...@git.apache.org>.

Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/115#discussion_r41702693
  
    --- Diff: core/conn/trafci/src/org/trafodion/ci/Properties/trafciDefaultLookAndFeel.properties ---
    @@ -1,3 +1,26 @@
    +#
    --- End diff --
    
    I thought we had put this file in the exception list ? Code won't be able to handle the copyright comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---