You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Pegoku (via GitHub)" <gi...@apache.org> on 2025/08/08 12:00:40 UTC

[I] Filters will not apply unless all are updated [superset]

Pegoku opened a new issue, #34617:
URL: https://github.com/apache/superset/issues/34617

   ### Bug description
   
   This bug is that the `Apply filters` button won't be clickable unless all filters are updated/modified.
   
   
   
   ### Screenshots/recordings
   
   https://github.com/user-attachments/assets/7243bd38-681d-4f93-a47b-4bd59b586e8d
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.11
   
   ### Node version
   
   18 or greater
   
   ### Browser
   
   Firefox
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-3169034392

   I think the bot is correct here, but let me know if you find otherwise!
   
   It *might* be a bit of confusing theming/styling here (cc @msyavuz ) but I _suspect_ that what's happening is you have the filter set as "required" and it's _suggesting_ a default value, but not _applying_ a value until one is selected. It might be that it just _looks_ like the `1` is selected, even though it's not?
   
   Can you confirm whether or not the "Filter has a default value" box is checked on that filter?
   
   <img width="328" height="97" alt="Image" src="https://github.com/user-attachments/assets/88941923-e13a-431c-bd52-b680af104519" />


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-4699434329

   Can you see if https://github.com/apache/superset/pull/36927 effectively fixed the issue? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "Pegoku (via GitHub)" <gi...@apache.org>.
Pegoku commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-3170523542

   Yes, the filters have that box checked.
   Btw, I won't be able to access to the superset instance until Monday, but I still can try to answer the questions as best as I can.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #34617: Filters will not apply unless all are updated
URL: https://github.com/apache/superset/issues/34617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-3167656853

   <!-- Greeting -->
   Hi @Pegoku! I'm [Dosu](https://go.dosu.dev/dosubot) and Iā€™m helping the superset team.
   
   <!-- Answer -->
   The "Apply filters" button is disabled if any required filter is missing a value or has a validation error, even if other filters have been changed. This is controlled by the checkIsApplyDisabled function in the FilterBar component, which checks for validation errors, unchanged filter states, and missing required values. As a result, the button can appear unclickable unless all required filters are set, which can feel like you must update every filter before applying changes. This is strict validation logic, not a recent regression, and recent changes (like accessibility or dependent filter improvements) haven't altered this core behavior. If you want to relax this requirement, it would involve changing the logic in checkIsApplyDisabled to allow partial filter updates or to only require that changed filters are valid and set.  
   [See FilterBar logic](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts)
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=hallucination) | [Report šŸ›](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/1020f7b7-a270-4e97-bebf-bfdf36661816?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
 b)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34617)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "Pegoku (via GitHub)" <gi...@apache.org>.
Pegoku commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-3173409835

   Hi. I checked and the filters do have the filter set as "required" with a default value.
   But the filter does apply when the page loads. Why does that happen if the filter doesn't get applied until it is selected?
   
   <img width="401" height="155" alt="Image" src="https://github.com/user-attachments/assets/5e69784a-55f8-4c09-b80d-49e80cd2e02e" />
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "den-kuz (via GitHub)" <gi...@apache.org>.
den-kuz commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-3854374422

   Seems like problem is in checkIsApplyDisabled -> checkIsValidateError procedure. One or more of filters marked as "error" in filterState.validateStatus, but its not error anymore after loading values


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Filters will not apply unless all are updated [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34617:
URL: https://github.com/apache/superset/issues/34617#issuecomment-4898775115

   Very likely fixed by PR #36927 (merged 2026-01-19: auto-apply filters with default values), which targets exactly the required-filter-with-default validateStatus problem identified in-thread. I already asked to confirm in June with no reply. Closing pending revalidation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org