You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "dongjiang1989 (via GitHub)" <gi...@apache.org> on 2024/09/13 10:34:29 UTC
[PR] Fix(discovery): fixendpoint slices flush_all/flush_expired bug [apisix]
dongjiang1989 opened a new pull request, #11577:
URL: https://github.com/apache/apisix/pull/11577
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop closed pull request #11577: fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired
URL: https://github.com/apache/apisix/pull/11577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3663470121
Since a similar PR already addresses this part, I'll close this PR for now. We can reopen it if there are any issues. Thank you for your contribution @dongjiang1989 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3446480097
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2567461068
cc @shreemaan-abhishek PTAL, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3126505767
> Hi @dongjiang1989, do you have time to work on this PR?
Yes. This pr work well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2428663461
> please add test cases
Thanks @shreemaan-abhishek .
Add e2e cases done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2370336469
please add test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2727309912
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2363081441
> please add test cases and explain the changes in detail and how it solves the issue.
Thanks @shreemaan-abhishek .
Add the changes done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2566307914
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11577: fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired
URL: https://github.com/apache/apisix/pull/11577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3341468258
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2370039718
/ok-to-test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3663311205
https://github.com/apache/apisix/pull/12288 is solving this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2428662230
/ok-to-test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-2835466614
Hi @dongjiang1989, please merge master branch code to run CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3125907401
Hi @dongjiang1989, do you have time to work on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3015157061
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(discovery): when `endpoint_slices` updated, old endpoints all flush_all/flush_expired [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #11577:
URL: https://github.com/apache/apisix/pull/11577#issuecomment-3030586889
Mark it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org