You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "cripto-bot (via GitHub)" <gi...@apache.org> on 2026/07/31 15:18:30 UTC
[PR] Extract StrBuilderTokenizer to its own file [commons-lang]
cripto-bot opened a new pull request, #1765:
URL: https://github.com/apache/commons-lang/pull/1765
## Summary
Extracts the StrBuilderTokenizer inner class from StrBuilder.java into its own top-level file.
## Motivation
- Follows the Single Responsibility Principle
- Reduces StrBuilder.java size from 3089 to ~3060 lines
- Improves code navigability and maintainability
- No functional changes — all existing behavior preserved
## Change
- Created `StrBuilderTokenizer.java` as a package-private class
- Updated constructor to accept `StrBuilder` reference (replaces `StrBuilder.this`)
- Updated `asTokenizer()` to pass `this` to the new constructor
- Removed inner class definition from StrBuilder.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extract StrBuilderTokenizer to its own file [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #1765: Extract StrBuilderTokenizer to its own file
URL: https://github.com/apache/commons-lang/pull/1765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extract StrBuilderTokenizer to its own file [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1765:
URL: https://github.com/apache/commons-lang/pull/1765#issuecomment-5144684195
@cripto-bot
Closing; Change for the sake of change. If you'd like to help, please fix bugs, improve Javadocs, and so on. No PRs for internal refactorings please. As a tangent, this creates a new top level class without accompanying tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org