You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/13 22:56:57 UTC

[GitHub] ilooner commented on issue #1429: DRILL-6676: Add Union, List and Repeated List types to Result Set Loader

ilooner commented on issue #1429: DRILL-6676: Add Union, List and Repeated List types to Result Set Loader
URL: https://github.com/apache/drill/pull/1429#issuecomment-412693176
 
 
   Thanks @paul-rogers . I'll run the functional tests and let you know if there are any issues. Since your code is always well documented and tested, I feel comfortable merging this pretty quickly. So maybe we can time-box the review to 2 weeks at most, unless some issue pops up.
   
   @sohami @bitblender since you guys have experience doing low level work with the vectors could you help with looking at this PR? The PR is quite big and would take me a while to go through by myself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services