You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/05/18 07:30:48 UTC
[GitHub] [camel-k] orpiske opened a new pull request #2307: Provide more information when the build fails
orpiske opened a new pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307
<!-- Description -->
Fix GH issue #2306
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Integration build error absent on the operator logs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske closed pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
orpiske closed pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#issuecomment-842940406
@astefanutti awesome, thanks! Let's close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#discussion_r634122676
##########
File path: pkg/controller/build/schedule_routine.go
##########
@@ -158,13 +159,16 @@ func (action *scheduleRoutineAction) runBuild(ctx context.Context, build *v1.Bui
}
if lastTask || taskFailed {
+ log.Errorf(nil, "Unable to complete the build: %s", status.Error)
Review comment:
Should it be logged when `lastTask` is truthy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#issuecomment-842938461
> I think it's fixed with [cd18611](https://github.com/apache/camel-k/commit/cd186118379eb53ae67adf7523a8bc65a65133e2) that's part of #2269.
>
> If you prefer to have your fix in earlier, could you please double check it's taken into account into the above?
I think this one can wait for #2269 (unless that one is not going on 1.5). I think it can wait for it to be merged and then I can add this on top of that since it's a much smaller patch. IMHO, we can close this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#issuecomment-842939826
> > I think it's fixed with [cd18611](https://github.com/apache/camel-k/commit/cd186118379eb53ae67adf7523a8bc65a65133e2) that's part of #2269.
> > If you prefer to have your fix in earlier, could you please double check it's taken into account into the above?
>
> I think this one can wait for #2269 (unless that one is not going on 1.5). I think it can wait for it to be merged and then I can add this on top of that since it's a much smaller patch. IMHO, we can close this for now.
Sounds good. Yes #2269 will be part of 1.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#issuecomment-842930170
With this patch, then it logs:
```
{"level":"error","ts":1621322905.2870088,"logger":"camel-k","msg":"Unable to complete build: could not pull base image image localhost:5000/openjdk11:slim: Get \"https://localhost:5000/v2/\": dial tcp 127.0.0.1:
5000: connect: connection refused","stacktrace":"github.com/apache/camel-k/pkg/util/log.Errorf\n\tgithub.com/apache/camel-k/pkg/util/log/log.go:201\ngithub.com/apache/camel-k/pkg/controller/build.(*scheduleRouti
neAction).runBuild\n\tgithub.com/apache/camel-k/pkg/controller/build/schedule_routine.go:162"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on a change in pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#discussion_r634125117
##########
File path: pkg/controller/build/schedule_routine.go
##########
@@ -158,13 +159,16 @@ func (action *scheduleRoutineAction) runBuild(ctx context.Context, build *v1.Bui
}
if lastTask || taskFailed {
+ log.Errorf(nil, "Unable to complete the build: %s", status.Error)
Review comment:
Yes it is. I forgot to test the happy path *facelpalm*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on a change in pull request #2307: Provide more information when the build fails
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2307:
URL: https://github.com/apache/camel-k/pull/2307#discussion_r634125117
##########
File path: pkg/controller/build/schedule_routine.go
##########
@@ -158,13 +159,16 @@ func (action *scheduleRoutineAction) runBuild(ctx context.Context, build *v1.Bui
}
if lastTask || taskFailed {
+ log.Errorf(nil, "Unable to complete the build: %s", status.Error)
Review comment:
Yes it is. I forgot to test the happy path **facelpalm**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org